Fix Prometheus metric naming, security, and documentation issues#259
Merged
YaroShkvorets merged 4 commits intoadd-clickhouse-rpc-metricsfrom Feb 3, 2026
Merged
Conversation
…dd tests Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com>
Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Prometheus metrics tracking for ClickHouse and RPC operations
Fix Prometheus metric naming, security, and documentation issues
Feb 3, 2026
YaroShkvorets
requested changes
Feb 3, 2026
Member
YaroShkvorets
left a comment
YaroShkvorets
left a comment
There was a problem hiding this comment.
@copilot We still want to include RPC url, not just true/false.
Just do sanitizeUrl() for it similar to clickhouse
Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com>
Contributor
Author
YaroShkvorets
approved these changes
Feb 3, 2026
Copilot stopped work on behalf of
YaroShkvorets due to an error
February 3, 2026 19:08
YaroShkvorets
added a commit
that referenced
this pull request
Feb 3, 2026
* Add Prometheus metrics tracking for ClickHouse and RPC operations * adjust buckets * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix Prometheus metric naming, security, and documentation issues (#259) * Initial plan * Address PR review comments: fix metric naming, JSDoc, security, and add tests Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com> * Improve JSDoc clarity and simplify fallback pattern Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com> * Use sanitized node_host instead of boolean node_url_configured Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com> * Fix Prometheus server state leak on startup failure (#261) * Initial plan * Fix Prometheus test failures by cleaning up server state on error Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com> * use bun sleep * lint --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com> Co-authored-by: YaroShkvorets <shkvorets@gmail.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: YaroShkvorets <29608734+YaroShkvorets@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_secondssuffix for Prometheus conventionsscraper_clickhouse_operationstoscraper_clickhouse_operations_secondsscraper_rpc_requeststoscraper_rpc_requests_secondstrackClickHouseOperationandtrackRpcRequestfunctions✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.